Add Semantic Role Labeling task by rmitsch · Pull Request #301 · explosion/spacy-llm

rmitsch · 2023-09-21T12:52:31Z

Description

This PR is for the addition of a fully working spacy pipeline for zero-shot span-based SRL using OpenAI. It includes the task, template, usage example, tests (pytest), and documentation.

Corresponding documentation PR

todo

Types of change

new feature

Checklist

I confirm that I have the right to submit this contribution under the project's MIT license.
I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
- all external tests (i. e. pytest ran with --external)
- all tests requiring a GPU (i. e. pytest ran with --gpu)
My changes require a change to the documentation, and I've added all the required information.

Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>

Added docs for srl response parsing

# Conflicts: # spacy_llm/tasks/__init__.py # spacy_llm/tasks/span.py

rmitsch

@ahmeshaf I refactored the task and left some comments. Also, the prediction tests fail locally. Can you look into that? Thanks! 🙏

rmitsch · 2023-09-22T08:50:53Z

More tests would be good - have a look at e. g. the SpanCat/NER tests for inspiration? E. g. the prompt identity tests.

working on this today

Thanks! Just ping me when you're done.

Merging explosion/spacy-llm into branch

ahmeshaf and others added 30 commits July 20, 2023 22:38

Adding span_srl task with tests, usage and documentation

07a4f2b

Fixing minor issues

22cba55

adding example usage of SRL

917868b

Merging main

0ff46ad

Fixing format warnings

b6f4f52

Fixing format warnings

d803b23

Fixing format warnings

53a494c

Fixing format warnings

dd7d9fb

Fix Literal ImportError

0ad6063

Fix Label assignment

15412b5

Fix the template's preamble

fd19441

Black formatting

b56c1d0

imports in alphabetical order

d6564f7

alignment_mode should be a Literal.

de68696

Update spacy_llm/tasks/srl_task.py

ed07c83

Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>

Update spacy_llm/tasks/templates/span-srl.v1.jinja

472d5c7

Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>

Update spacy_llm/tests/tasks/test_span_srl.py

55a8018

Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>

reformatting

355241a

Merge branch 'main' of github.com:ahmeshaf/spacy-llm

a63d610

reformatting

84d17df

adding test on srl roles

666c3ee

SRLTask inherits SpanTask

cb81bdf

Merge branch 'explosion:main' into main

c6d0dfd

Added label definitions rendering in prompt

6ab4723

Reformatting

037f36f

Restructuring SRLExample and ARGRelItem

d6faecd

added expected response

2a4e862

Removing print statement

b380478

Added few-shot span-srl

8fc6b8d

Add examples path in srl docs

73bf0f6

ahmeshaf and others added 6 commits August 8, 2023 12:24

removing whitespaces causing commit check failures

824aa82

Make SRLExample hashable to remove duplicate examples

6d5efc9

Add doc-tailored examples in generate_prompts

2a9ede5

Added defs for alignment modes

be50655

Added docs for srl response parsing

fix serialization issue of pred_item

0970e64

Update spacy_llm/tests/tasks/test_span_srl.py

3e0a50e

rmitsch added feat/new New feature feat/task Feature: tasks labels Sep 21, 2023

rmitsch self-assigned this Sep 21, 2023

rmitsch mentioned this pull request Sep 21, 2023

Adding span_srl task with tests, usage and documentation #226

Closed

3 tasks

rmitsch changed the title ~~Feat/srl~~ Adding span_srl task with tests, usage and documentation Sep 21, 2023

rmitsch added 3 commits September 21, 2023 14:57

Merge branch 'main' into feat/srl

30fc8e1

# Conflicts: # spacy_llm/tasks/__init__.py # spacy_llm/tasks/span.py

Refactor to fit SRLTask into new task structure.

6e40fba

Format.

deba894

rmitsch changed the title ~~Adding span_srl task with tests, usage and documentation~~ Adding Semantic Role Labeling task Sep 22, 2023

rmitsch changed the title ~~Adding Semantic Role Labeling task~~ Add Semantic Role Labeling task Sep 22, 2023

rmitsch added 5 commits September 22, 2023 10:10

Format.

c57c058

Allow arbitrary types in SRLExample.

4daa3af

Format.

9ef0565

Fix typing issues.

1bdb0b4

Format.

3e9d72f

rmitsch added the Test external Run external tests label Sep 22, 2023

rmitsch commented Sep 22, 2023

View reviewed changes

rmitsch removed the Test external Run external tests label Sep 22, 2023

ahmeshaf added 6 commits October 6, 2023 13:00

Merge pull request #1 from explosion/main

0338389

Merging explosion/spacy-llm into branch

Fixing pydantic parsing error for dicts

c6b8e55

adding params/returns documentation

e654805

black formatting

6d3eb19

Merge branch 'feat/srl' of github.com:ahmeshaf/spacy-llm into feat/srl

8aaba47

Merge branch 'explosion:main' into feat/srl

574c602

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Semantic Role Labeling task#301

Add Semantic Role Labeling task#301
rmitsch wants to merge 50 commits into
explosion:mainfrom
ahmeshaf:feat/srl

rmitsch commented Sep 21, 2023 •

edited

Loading

Uh oh!

rmitsch left a comment

Uh oh!

Uh oh!

rmitsch Sep 22, 2023

Uh oh!

ahmeshaf Oct 6, 2023

Uh oh!

rmitsch Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

rmitsch commented Sep 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Corresponding documentation PR

Types of change

Checklist

Uh oh!

rmitsch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rmitsch Sep 22, 2023

Choose a reason for hiding this comment

Uh oh!

ahmeshaf Oct 6, 2023

Choose a reason for hiding this comment

Uh oh!

rmitsch Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rmitsch commented Sep 21, 2023 •

edited

Loading